Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh expired token #15

Merged
merged 3 commits into from
May 6, 2024
Merged

Refresh expired token #15

merged 3 commits into from
May 6, 2024

Conversation

allthesignals
Copy link
Contributor

  • Adds an API-only route (JSON HTTP)
  • Namespaced to Argyle
  • Uses Argyle's user-tokens endpoint to refresh
  • Hooks into the Link widgets "onTokenExpired" event to issue the refresh.

Caveats:

  • Currently does not handle for updates to the session... unsure how best to manage this.

@allthesignals allthesignals requested a review from tdooner May 3, 2024 14:22
GeorgeCodes19
GeorgeCodes19 approved these changes May 3, 2024
View reviewed changes
app/controllers/api/argyle_controller.rb

private

def refresh_token(argyle_user_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, this is an instance of a method that I'll add to the Argyle Service

@allthesignals allthesignals merged commit 9f52ec5 into main May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeCodes19 GeorgeCodes19 GeorgeCodes19 approved these changes

@tdooner tdooner Awaiting requested review from tdooner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allthesignals @GeorgeCodes19