Skip to content

Commit

Permalink
Attempt to fix vulnerability (#416)
Browse files Browse the repository at this point in the history
* Fix vulnerability

* Add rails/.env to the accept files

* Pin specific version

* Set correct header

* Ignore low risk threat
  • Loading branch information
allthesignals authored Jan 22, 2025
1 parent 9d857d5 commit c94dec3
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .dockleconfig
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This file is allows you to specify a list of files that is acceptable to Dockle
# To allow multiple files, use a list of names, example below. Make sure to remove the leading #
DOCKLE_ACCEPT_FILES=database.yml,omniauth.rb
DOCKLE_ACCEPT_FILES=database.yml,omniauth.rb,rails/.env
# https://github.com/goodwithtech/dockle#accept-suspicious-environment-variables--files--file-extensions
2 changes: 1 addition & 1 deletion .github/workflows/owasp-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
database_url: ${{ steps.setup.outputs.database_url }}

- name: Run OWASP Full Scan
uses: zaproxy/action-full-scan@v0.11.0
uses: zaproxy/action-full-scan@v0.12.0
with:
target: 'http://localhost:3000/'
fail_action: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/rspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
jobs:
rspec:
name: Rspec
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
services:
postgres:
image: postgres
Expand Down
2 changes: 1 addition & 1 deletion app/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ RUN apt-get update -qq && \
curl=7.88.1-10+deb12u8 \
libgpgme11=1.18.0-3+b1 \
libvips42=8.14.1-3+deb12u1 \
linux-libc-dev=6.1.119-1 \
linux-libc-dev=6.1.123-1 \
openssl=3.0.15-1~deb12u1 \
postgresql-client=15+248 \
python-is-python3=3.11.2-1+deb12u1 \
Expand Down
2 changes: 2 additions & 0 deletions app/zap.conf
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
# Perms Policy not supported in rails https://github.com/rails/rails/issues/48878
# Also not fully adopted: https://caniuse.com/permissions-policy
10063 IGNORE Permissions Policy Header Not Set
# Low risk
90004 IGNORE Insufficient Site Isolation Against Spectre Vulnerability
10003 WARN (Vulnerable JS Library - Passive/release)
10010 FAIL (Cookie No HttpOnly Flag - Passive/release)
10011 FAIL (Cookie Without Secure Flag - Passive/release)
Expand Down

0 comments on commit c94dec3

Please sign in to comment.