Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form: v0.1.0 schema + user testing feedback #21

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

natalialuzuriaga
Copy link
Contributor

@natalialuzuriaga natalialuzuriaga commented Feb 7, 2025

Problem

Various updates have been made to the code.json schema and @sachin-panayil did some user testing so updating the form accordingly.

Solution

  • Added new fields from code.json v0.1.0
  • Added new form component for integers. Integers takes whole numbers vs number components supports decimals

Addressed low hanging fruit from user testing:

  • Updated field descriptions for clarity. Add links where applicable
  • Disabled time setting for date-time component for ease of use. The GH action will update the date values accordingly
  • Labels of object fields are now shown along with their descriptions

Test Plan

  1. Start up a HTTP server using python: python3 -m http.server 8000
  2. Fill out the form
  3. Click submit and downloads code.json. File contents should match what was submitted in the form!

or try it here after merged:
https://dsacms.github.io/codejson-generator

@natalialuzuriaga natalialuzuriaga marked this pull request as ready for review February 7, 2025 22:25
@natalialuzuriaga natalialuzuriaga changed the title Added new fields from schema v0.1.0 and updated form accordingly Form: v0.1.0 schema + user testing feedback Feb 7, 2025
Copy link
Contributor

@decause-gov decause-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor edit, but other than that, LGTM +1 🚢

@sachin-panayil
Copy link
Collaborator

  • i was confused on the project and systems fields. i think a more in depth description would be helpful
  • other changes are great, i pulled the branch and tested and it worked perfect

Signed-off-by: Natalia Luzuriaga <[email protected]>
@natalialuzuriaga natalialuzuriaga merged commit 6cb1d93 into main Feb 10, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants