Skip to content

Commit

Permalink
[#43] Replace jobs.irods.* properties with irods.admin.* properties
Browse files Browse the repository at this point in the history
This commit removes the jobs.irods.* properties.
  • Loading branch information
JustinKyleJames authored and alanking committed Dec 13, 2024
1 parent 594780f commit f938d6d
Show file tree
Hide file tree
Showing 43 changed files with 62 additions and 80 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class TestCreateTicketWithGroupRestriction {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
2 changes: 1 addition & 1 deletion emc-metalnx-core/attic/TestDownloadWithTicket.java
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public class TestDownloadWithTicket {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
4 changes: 2 additions & 2 deletions emc-metalnx-core/attic/TestTicketAuthenticatedAccess.java
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ public class TestTicketAuthenticatedAccess {
@Value("${irods.port}")
private String port;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Value("${jobs.irods.password}")
@Value("${irods.admin.password}")
private String password;

@Autowired
Expand Down
2 changes: 1 addition & 1 deletion emc-metalnx-core/attic/TestTicketWithGroupRestriction.java
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public class TestTicketWithGroupRestriction {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
2 changes: 1 addition & 1 deletion emc-metalnx-core/attic/TestUploadWithTicket.java
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class TestUploadWithTicket {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
6 changes: 0 additions & 6 deletions emc-metalnx-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,6 @@

######################################

jobs.irods.username=${jargon.test.irods.admin}
jobs.irods.password=${jargon.test.irods.admin.password}
jobs.irods.auth.scheme=${metalnx.auth.scheme}
runSyncJobs=true


rmd.connection.timeout=500
rmd.connection.port=8000

Expand Down
6 changes: 0 additions & 6 deletions emc-metalnx-services/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -244,12 +244,6 @@

######################################

jobs.irods.username=${jargon.test.irods.admin}
jobs.irods.password=${jargon.test.irods.admin.password}
jobs.irods.auth.scheme=${metalnx.auth.scheme}
runSyncJobs=true


rmd.connection.timeout=500
rmd.connection.port=8000

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
public class EncodedPropertiesConfigurer extends PropertyPlaceholderConfigurer {

private static final String PROPERTIES_TO_BE_DECODED = "encoded.properties";
private static final String DEFAULT_ENCODED_FIELDS = "db.password,jobs.irods.password";
private static final String DEFAULT_ENCODED_FIELDS = "db.password,irods.admin.password";
private static final String PWD_SALT = "!M3t4Lnx@1234";

private static final Logger logger = LoggerFactory.getLogger(EncodedPropertiesConfigurer.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@ public class ConfigServiceImpl implements ConfigService {
@Value("${irods.zoneName}")
private String irodsZone;

@Value("${jobs.irods.username}")
private String irodsJobUser;
@Value("${irods.admin.user}")
private String irodsAdminUser;

@Value("${jobs.irods.password}")
private String irodsJobPassword;
@Value("${irods.admin.password}")
private String irodsAdminPassword;

@Value("${jobs.irods.auth.scheme}")
@Value("${irods.auth.scheme}")
private String irodsAuthScheme;

@Value("${populate.msi.enabled}")
Expand Down Expand Up @@ -189,13 +189,13 @@ public String getIrodsZone() {
}

@Override
public String getIrodsJobUser() {
return irodsJobUser;
public String getIrodsAdminUser() {
return irodsAdminUser;
}

@Override
public String getIrodsJobPassword() {
return irodsJobPassword;
public String getIrodsAdminPassword() {
return irodsAdminPassword;
}

@Override
Expand Down Expand Up @@ -367,8 +367,8 @@ public String toString() {
if (irodsZone != null) {
builder.append("irodsZone=").append(irodsZone).append(", ");
}
if (irodsJobUser != null) {
builder.append("irodsJobUser=").append(irodsJobUser).append(", ");
if (irodsAdminUser != null) {
builder.append("irodsAdminUser=").append(irodsAdminUser).append(", ");
}
if (irodsAuthScheme != null) {
builder.append("irodsAuthScheme=").append(irodsAuthScheme).append(", ");
Expand Down Expand Up @@ -439,13 +439,13 @@ public void setIrodsZone(String irodsZone) {
}

@Override
public void setIrodsJobUser(String irodsJobUser) {
this.irodsJobUser = irodsJobUser;
public void setIrodsAdminUser(String irodsAdminUser) {
this.irodsAdminUser = irodsAdminUser;
}

@Override
public void setIrodsJobPassword(String irodsJobPassword) {
this.irodsJobPassword = irodsJobPassword;
public void setIrodsAdminPassword(String irodsAdminPassword) {
this.irodsAdminPassword = irodsAdminPassword;
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ private void authenticateIRODSAccount() throws JargonException {
String host = configService.getIrodsHost();
int port = Integer.parseInt(configService.getIrodsPort());
String zone = configService.getIrodsZone();
String user = configService.getIrodsJobUser();
String password = configService.getIrodsJobPassword();
String user = configService.getIrodsAdminUser();
String password = configService.getIrodsAdminPassword();
String authScheme = configService.getIrodsAuthScheme();
String resc = "";
String homeDir = "";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class TestAddDataGridMetadataListToColls {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class TestAddDataGridMetadataListToObjs {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public class TestAddDataGridMetadataToColls {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class TestAddDataGridMetadataToObjs {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class TestAddMetadataToColls {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class TestAddMetadataToObjs {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class TestCopyCollWithMetadata {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class TestCopyObjWithMetadata {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public class TestMetadataCase {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class TestMostRestrictivePermission {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public class TestReadPermissionOnFiles {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public class TestTicketWithByteLimit {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class TestTicketWithExpirationDate {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public class TestTicketWithFilesLimit {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public class TestTicketWithHostRestriction {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Value("${irods.host}")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public class TestTicketWithUserRestriction {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class TestTicketWithUsesLimit {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public class TestCreateDuplicatedTicket {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class TestCreateTicket {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class TestCreateTicketWithByteLimit {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class TestCreateTicketWithExpirationDate {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class TestCreateTicketWithFilesLimit {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class TestCreateTicketWithHostRestriction {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Value("${irods.host}")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public class TestCreateTicketWithUserRestriction {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class TestCreateTicketWithUsesLimit {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class TestDeleteTickets {
@Value("${irods.zoneName}")
private String zone;

@Value("${jobs.irods.username}")
@Value("${irods.admin.user}")
private String username;

@Autowired
Expand Down
Loading

0 comments on commit f938d6d

Please sign in to comment.