Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Data Models #172

Merged
merged 6 commits into from
Nov 12, 2024
Merged

More Data Models #172

merged 6 commits into from
Nov 12, 2024

Conversation

chrisvanrun
Copy link
Contributor

@chrisvanrun chrisvanrun commented Nov 8, 2024

This PR contains some extracted (or more re-achieved) changes from:

When I was doing a major re-haul and unwisely decided that, since I was touching nearly everything, it made most sense to push the changes upon the already large change set.

This PR does two major things:

  • Allow object/model retrieval using api_url (was done with the direct request, now forced through the APIs)
  • Fix resulting deprecation warnings on key access (i.e. object["pk"]

It also makes the recurse_call wrapper more robust by outputting the error (raise from e) and allowing for retries when ObjectNotFound is thrown.

Widespread changeset, but relatively simple changes.

@chrisvanrun chrisvanrun requested a review from amickan November 8, 2024 10:43
gcapi/apibase.py Outdated Show resolved Hide resolved
tests/utils.py Outdated Show resolved Hide resolved
tests/utils.py Outdated Show resolved Hide resolved
Copy link
Member

@jmsmkn jmsmkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small comments.

@chrisvanrun chrisvanrun merged commit b063078 into main Nov 12, 2024
14 checks passed
@chrisvanrun chrisvanrun deleted the minor-fixes branch November 12, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants