Skip to content

Automatic release workflow completed
Compare
Choose a tag to compare
@github-actions github-actions released this 20 Sep 10:03
· 28 commits to main since this release
v3.0
7e49c25
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Hi @johentsch, after taking in consideration the feedback. I think this version could be merged to the main branch. Nevertheless, There are couple of things that needs to be mentioned for this PR:

  • Rather than using the https://github.com/marketplace/actions/automatic-releases, I swapped the action with https://github.com/marketplace/actions/create-release, the main reason for this decision is that automatic releases requires some changes to its source, there has not been much support for two years, and the mechanism to create the action in the marketplace is a bit ambiguous.

  • For the zenodo and citation files, there are two ways in which we could replace the tags, which one would you prefer?

    • The old tag is used to replace strings in the files
    • Using a regex with pattern v\d+\.(\d+\.\d+|\d+) to replace strings in the files

    Notice: the advantage of using regex is that for any string version which is not the latest tag, these will still update with the new tag

  • It does not seem possible to update the zenodo and citation files when the PR is being merged, a simple solution is to push these changes to the main branch once the PR is merged, what do you think about this?

  • When applying transform, should we commit and push the generated files ?

Contributors

johentsch
Assets 2
Loading