Some enhancements #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBa2016
reviewed
Nov 25, 2020
| @@ -371,27 +377,44 @@ async def updateValues(self, mqttc): | |||
| if "calc" in self.statusValues[stateId]: | |||
| state["value"] = self.statusValues[stateId]["calc"](state["value"]) | |||
| _LOGGER.info("%s -> %s(%s)" %(self.statusValues[stateId]["statusName"], state["textId"], state["value"])) | |||
| stopic = "skoda2mqtt/%s_%s/STATE"% (vin, self.statusValues[stateId]["statusName"]) | |||
| stopic = "skoda2mqtt/%s/%s/STATE"% (vin, self.statusValues[stateId]["statusName"]) | |||
There was a problem hiding this comment.
You cannot nest that much if you want this to be working with Home Assistant. I was not able to get anything with more than one nesting level (skoda2mqtt/<measurement_name>/STATE) working. Please revert this before I can merge the PR.
There was a problem hiding this comment.
I have it running that way some months (HA 0.115 till HA 0.118)
What I have found is if the discovery topic is not retained then the HA has to be started before this starts.
I would change the retain state of the discovery topic.
DBa2016
reviewed
Nov 25, 2020
|
|
||
| WORKDIR /usr/src/app | ||
|
|
||
| RUN git clone https://github.com/zaubererty/sc2mqtt.git . |
There was a problem hiding this comment.
Please refer to the original repo here, not to a fork.
There was a problem hiding this comment.
Valid point, going to change that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Docker support
Enhanced pip setup
streamlined MQTT nodes and added device for more structure