fix networkinterfaces processes #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace indexing by variables named start/end and prefix/suffix.
ifquery excluded the last digit of interfaces range given. ex: eth[1-2] would give only eth1 instead of eth1 + eth2. This commit fix this behavior by increasing the range in expand_iface_range.
The commit make the auto_ifaces container pointing to the allow_classes['auto'] list. (since it's a mutable object, we get the same instance)
This change goal is to make auto behave like allow-auto. This commit will also provide the interfaces range capability to any other allow-class names.
The only real change is the creation of a ifaceobj before testing it's name. (The ifaceobj will still not be added if deemed invalid)
This commit fix the following by making an understandable error msg: * the 'allow eth0' would make a IndexError shown to the user. * the 'allow-' would be valid and use an empty classname.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of: #235.
This will be a series of PRs, and this is Part 1 where only the Python code is affected. The aim is to fix any potential errors or missbehavior (no breaking changes should be present).
(Part 2 will focus on hotplug/udev handling, and Part 3 will involve reworking and questioning the arguments. Each part should be independent and merge without conflicts with the other two.)
This PR includes the following changes: