[pull] main from ghostty-org:main #110
Merged
+27
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Fixes #6633 For macOS, we set LANGUAGE to the priority list of preferred languages for the app bundle, using the GNU gettext priority list format (colon separated list of language codes). This previously was inherited by the termio env. At first, this was by design, but this has inherent flaws. Namely, the priority list format is a GNU gettext specific format, and programs that use alternate gettext implementations (like musl or Python) do not understand it and actually do the wrong thing (not their fault!). This change removes the inheritance of LANGUAGE in the termio env. To make it extra safe, we only do set and unset LANGUAGE when we know we launch from an app bundle. That was always the desired behavior but this makes it more explicit.
…#6648) Fixes #6633 For macOS, we set LANGUAGE to the priority list of preferred languages for the app bundle, using the GNU gettext priority list format (colon separated list of language codes). This previously was inherited by the termio env. At first, this was by design, but this has inherent flaws. Namely, the priority list format is a GNU gettext specific format, and programs that use alternate gettext implementations (like musl or Python) do not understand it and actually do the wrong thing (not their fault!). This change removes the inheritance of LANGUAGE in the termio env. To make it extra safe, we only do set and unset LANGUAGE when we know we launch from an app bundle. That was always the desired behavior but this makes it more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )