Merge pull request #1620 from CounterpartyXCP/hotfix

HOTFIX IndexError
CounterpartyXCP · Apr 10, 2024 · 2173d10 · 2173d10
2 parents c7690e6 + c297e91
commit 2173d10
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/counterparty-lib/counterpartylib/lib/address.py b/counterparty-lib/counterpartylib/lib/address.py
@@ -5,6 +5,7 @@
 from counterpartylib.lib import config
 from counterpartylib.lib import script
 from counterpartylib.lib import ledger
+from counterpartylib.lib import exceptions
 
 logger = logging.getLogger(config.LOGGER_NAME)
 
@@ -53,6 +54,9 @@ def unpack(short_address_bytes):
     """
     from .ledger import enabled # Here to account for test mock changes
 
+    if short_address_bytes == b'':
+        raise exceptions.UnpackError
+
     if enabled('segwit_support') and short_address_bytes[0] >= 0x80 and short_address_bytes[0] <= 0x8F:
         # we have a segwit address here
         witver = short_address_bytes[0] - 0x80

diff --git a/release-notes/release-notes-v10.0.1.md b/release-notes/release-notes-v10.0.1.md
@@ -0,0 +1,9 @@
+# Release Notes - Counterparty Core v10.0.1 (2024-04-09)
+
+# ChangeLog
+
+## Stability and Correctness
+* Add missing sanity check in address unpacking for dispenser that causes a complete network crash
+
+# Credits
+* Adam Krellenstein
diff --git a/release-notes/release-notes-v9.61.3.md b/release-notes/release-notes-v9.61.3.md
@@ -0,0 +1,9 @@
+# Release Notes - Counterparty Core v9.61.3 (2024-04-09)
+
+# ChangeLog
+
+## Stability and Correctness
+* Add missing sanity check in address unpacking for dispensers that causes a complete network crash
+
+# Credits
+* Adam Krellenstein