Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement-centered-the-text #630

Merged
merged 5 commits into from
May 30, 2024

Conversation

Ayushmaanagarwal1211
Copy link
Contributor

Description

I have changed some css for making the all text for small screen sizes to the center .

Fixes #612

Screenshots

Screenshot 2024-05-27 195746

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

Copy link

netlify bot commented May 27, 2024

👷 Deploy request for counsellor-startup pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 76eb38f

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Contributor

deepsource-io bot commented May 27, 2024

Here's the code health analysis summary for commits 9933433..76eb38f. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 8 occurences introduced
🎯 3 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@thestarsahil
Copy link
Collaborator

Changes , Not statisfied
image

We want this change , Kindly Work on that

@Ayushmaanagarwal1211
Copy link
Contributor Author

@thestarsahil sir from where i can get these images .
Screenshot 2024-05-29 104320

@thestarsahil
Copy link
Collaborator

@thestarsahil sir from where i can get these images . Screenshot 2024-05-29 104320

/src/assets/10.png
You can find more avatar like this , its already in assets folder

@Ayushmaanagarwal1211
Copy link
Contributor Author

ok sir

@Ayushmaanagarwal1211
Copy link
Contributor Author

Ayushmaanagarwal1211 commented May 29, 2024

Sir is this alright
Screenshot 2024-05-29 193948

@thestarsahil
Copy link
Collaborator

@Ayushmaanagarwal1211 We will discuss this in discord VC at 10pm

@Ayushmaanagarwal1211
Copy link
Contributor Author

I did some changes please check

bandicam.2024-05-29.23-05-10-368.mp4

@thestarsahil
Copy link
Collaborator

Screenshot from 2024-05-30 09-00-19

Responsive part not done yet !

@Ayushmaanagarwal1211
Copy link
Contributor Author

Ok will do

@Ayushmaanagarwal1211
Copy link
Contributor Author

Done

bandicam.2024-05-30.09-36-18-351.mp4

@thestarsahil
Copy link
Collaborator

@Ayushmaanagarwal1211 reduce the font size and change the font style to ABeeZee

@Ayushmaanagarwal1211
Copy link
Contributor Author

Screenshot 2024-05-30 203756
Can you check it again

@thestarsahil thestarsahil merged commit be9db53 into Counselllor:master May 30, 2024
1 of 2 checks passed
@thestarsahil
Copy link
Collaborator

Right Now , I'm merging
Raise Another PR to Fix this CSS property again !
Well done @Ayushmaanagarwal1211

@Ayushmaanagarwal1211
Copy link
Contributor Author

Ayushmaanagarwal1211 commented May 30, 2024

Ok Sir and i see on discord that PR's is not counted for leaderboard i think this is due to not added GSSOC and level label on PR's merged so please add level . And if you think that this PR is capable of getting level 3 so please add it .

@Ayushmaanagarwal1211
Copy link
Contributor Author

@thestarsahil please put gssoc and level label

@thestarsahil thestarsahil added gssoc for GSSOC'24 contributors level2 labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc for GSSOC'24 contributors level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The text in the college page is to be centered .
2 participants