Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated About Us Page #589

Merged
merged 12 commits into from
May 25, 2024
Merged

Updated About Us Page #589

merged 12 commits into from
May 25, 2024

Conversation

Hemashree21
Copy link
Contributor

@Hemashree21 Hemashree21 commented May 24, 2024

Resolved issue #587

I redesigned the cards and added animation effects on hover. I have made the section responsive as well.

Screenshot 2024-05-24 140808

@thestarsahil please check and let me know if any changes are required.

Signed-off-by: Hemashree M S <[email protected]>
Copy link

netlify bot commented May 24, 2024

👷 Deploy request for counsellor-startup pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a09f165

Copy link
Contributor

deepsource-io bot commented May 24, 2024

Here's the code health analysis summary for commits 2597a2d..a09f165. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 136 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
@Hemashree21
Copy link
Contributor Author

@thestarsahil I resolved all other Deepsource conflicts except 1, which is maximum depth. If I have to resolve that I will have to change the complete code. And this fix is just to make the code more readable so I didn't resolve it. Please let me know if I have to resolve that as well.

@thestarsahil
Copy link
Collaborator

@Hemashree21 Yes you have to resolve this ! The Deepsource have to clear all test case you made you make more code readable and understable !

Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
@Hemashree21
Copy link
Contributor Author

Hemashree21 commented May 25, 2024

@thestarsahil I resolved all conflicts and made each section of the code as a reusable component. Can you please assign level 3 to this PR? It took me a lot of time to resolve all the issues.

@thestarsahil
Copy link
Collaborator

Screenshot from 2024-05-25 14-13-33
Screenshot from 2024-05-25 14-13-26

Update and fix this ...
Font family should be "ABeeZee"
College card back side not visible

@thestarsahil thestarsahil added gssoc for GSSOC'24 contributors level3 labels May 25, 2024
Signed-off-by: Hemashree M S <[email protected]>
@Hemashree21
Copy link
Contributor Author

@thestarsahil I updated the changes

@thestarsahil
Copy link
Collaborator

Reflecting the same issue ..

@Hemashree21
Copy link
Contributor Author

image

Sir the font is changed and the background for cards, these were the only 2 changes right? Or were there anything else?

@Hemashree21
Copy link
Contributor Author

image

I have made the changes in commit ccc8aa1 can you please check that as well? It's working correctly in my server.

Copy link
Collaborator

@thestarsahil thestarsahil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge !

@thestarsahil thestarsahil merged commit fdfaf5b into Counselllor:master May 25, 2024
3 checks passed
@Hemashree21
Copy link
Contributor Author

Thankyou!

@Hemashree21
Copy link
Contributor Author

@thestarsahil can you please assign this PR to me, it wasn't included in the leaderboard. Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc for GSSOC'24 contributors level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants