-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated About Us Page #589
Conversation
Signed-off-by: Hemashree M S <[email protected]>
👷 Deploy request for counsellor-startup pending review.Visit the deploys page to approve it
|
Here's the code health analysis summary for commits Analysis Summary
|
Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
@thestarsahil I resolved all other Deepsource conflicts except 1, which is maximum depth. If I have to resolve that I will have to change the complete code. And this fix is just to make the code more readable so I didn't resolve it. Please let me know if I have to resolve that as well. |
@Hemashree21 Yes you have to resolve this ! The Deepsource have to clear all test case you made you make more code readable and understable ! |
Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
@thestarsahil I resolved all conflicts and made each section of the code as a reusable component. Can you please assign level 3 to this PR? It took me a lot of time to resolve all the issues. |
Signed-off-by: Hemashree M S <[email protected]>
Signed-off-by: Hemashree M S <[email protected]>
@thestarsahil I updated the changes |
Reflecting the same issue .. |
I have made the changes in commit ccc8aa1 can you please check that as well? It's working correctly in my server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge !
Thankyou! |
@thestarsahil can you please assign this PR to me, it wasn't included in the leaderboard. Thankyou! |
Resolved issue #587
I redesigned the cards and added animation effects on hover. I have made the section responsive as well.
@thestarsahil please check and let me know if any changes are required.