Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/toggle profile at profile header #1200

Conversation

anwesha2002
Copy link

Description

This PR adds a new feature that is when user click on the profile icon in the profile navbar it gets open and vice-versa which creates a dynamic profile button

in issue #1145 I raised 2 days ago , it doesn't persist anymore someone already has fixed that issue . So I am making this PR which makes the profile icon dynamic in the profile page. I have checked that nobody has raised this issue

Fixes #1145

Replace issue_no with the issue number which is fixed in this PR

Screenshots

Recording.2024-07-22.204435.mp4

Checklist

  • [ x] Tests have been added or updated to cover the changes
  • [ x] Documentation has been updated to reflect the changes
  • [x ] Code follows the established coding style guidelines
  • [ x] All tests are passing

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for counsellor-startup ready!

Name Link
🔨 Latest commit f1bf40e
🔍 Latest deploy log https://app.netlify.com/sites/counsellor-startup/deploys/66a6528f6122600008eea2e2
😎 Deploy Preview https://deploy-preview-1200--counsellor-startup.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 71
Accessibility: 96
Best Practices: 100
SEO: 75
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Contributor

deepsource-io bot commented Jul 22, 2024

Here's the code health analysis summary for commits f0592b6..f1bf40e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 7 occurences introduced
🎯 4 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@thestarsahil
Copy link
Collaborator

@anwesha2002 Can you please pull down the latest changes and then push again
It's your time to merge PR

…into feat/toggle_Profile_at_profile_header
@anwesha2002
Copy link
Author

@anwesha2002 Can you please pull down the latest changes and then push again It's your time to merge PR

@thestarsahil I pulled it down again pushed it

@thestarsahil
Copy link
Collaborator

resolve conflict push again

anwesha and others added 3 commits July 28, 2024 11:19
…into feat/toggle_Profile_at_profile_header

# Conflicts:
#	src/components/ProfileComponent/ProfileCard.jsx
@thestarsahil thestarsahil merged commit b47d671 into Counselllor:master Jul 28, 2024
5 of 6 checks passed
@thestarsahil thestarsahil added gssoc for GSSOC'24 contributors level2 labels Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc for GSSOC'24 contributors level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images of courses are not visible
2 participants