Fix permanent shutdowns (TLS & 1000 close code) #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guarantees that both the easy and multi handle are recreated from scratch
Fixes previous commit, ensuring that it will initialize gateway before the usage of functions that request its structure, and to clean up only on the complete shutdown.
This commit fixes the issue that it wouldn't reconnect on 1000 close codes.
This commit fixes the issue that once a TLS notify was received, it wouldn't call on_close, ending up stuck in loop, not reconnecting.
This commit fixes an issue that the discord-loop loop wouldn't be breaken to reconnect, causing the bot to be stuck in the state of disconnected. Co-authored-by: Lucas Müller <[email protected]>
lcsmuller
reviewed
Jan 30, 2024
This commit updated the message that is printed to the terminal when a `ws_close` is called on a connection that has already ended.
This commit reverts a cleanup that is unnecessary as it's expected that `discord_cleanup` is called after `discord_run`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
to test it before making changes to Concord.
What?
This PR fixes an fatal issue that would block Concord from reconnecting to the gateway.
Why?
To allow bots to run for a long time, not being disconnecting without reconnecting.
How?
This includes various fixes about connections, both TLS and 1000 WS status code.
Testing?
It was tested by persons on Cogmaster's Discord and verified that the fix is working, properly reconnecting when disconnected abruptly.