-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webapp fix #397
Webapp fix #397
Conversation
Looks good to me. |
I think: please make the main fix which is about failing tests before merge. |
This PR will make the webapp temporarily functional. |
are the tests failing due to #398 ? |
The tests are not failing because of that issue. They are failing due to some injection issue (which I am not sure how to fix). But that is not the point; Look at the current tests: https://github.com/IllinoisCogComp/saul/tree/master/saul-webapp/test |
Okaayy. |
Pending:
Towards #381