Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scroll down not reaching the bottom entry #961

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: scroll down not reaching the bottom entry #961

wants to merge 2 commits into from
+6 −1

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Nov 21, 2024 •
edited
Loading

Type of Change

  • Bug fix

Description

  • Fix scroll down not reaching bottom entry in a sub category like communication apps, developer tools, etc.

Testing

  • Tested on Arch Linux without issues.

Issues

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

lj3954
lj3954 suggested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@lj3954 lj3954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable name could be a little more clear.

tui/src/state.rs Outdated Show resolved Hide resolved
tui/src/state.rs Outdated Show resolved Hide resolved
@adamperkowski adamperkowski changed the title Fix scroll down not reaching bottom entry fix: scroll down not reaching the bottom entry Nov 22, 2024
@adamperkowski adamperkowski added the bug Something isn't working label Nov 22, 2024
@jeevithakannan2 jeevithakannan2 mentioned this pull request Jan 24, 2025
Closed
4 tasks
@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Feb 2, 2025

what do you think about the changes in #1015 it also includes this fix with refactoring of both scroll up and down functions

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Feb 2, 2025 •
edited
Loading

the code looks a lot better now, and is more readable. Do you want me to drop these changes? since they are kind of duplicating the changes in this merge request.

@nnyyxxxx nnyyxxxx mentioned this pull request Feb 2, 2025
Merged
@nnyyxxxx
Copy link
Contributor

superseded by #1015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lj3954 lj3954 lj3954 approved these changes

@adamperkowski adamperkowski adamperkowski approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cant choose last options inside a folder
4 participants
@jeevithakannan2 @nnyyxxxx @lj3954 @adamperkowski