Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get title of Image on URL and display on sidebar #5

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

Chinazaekpere-Ike
Copy link
Owner

@Chinazaekpere-Ike Chinazaekpere-Ike commented Oct 25, 2022

I have fetched the name of the image from the inputted URL. This is the same name which the user originally saved their image on archive.org

This gotten image name s now displayed on the sidebar (beneath the gotten image) as the Image title

Fixes publiclab#1202

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

20221021_004616

@jywarren Hope this looks good.

Fetch the name of URL the user saved the image as on arcive.org from the URL and display title on sidebar
@Chinazaekpere-Ike Chinazaekpere-Ike merged commit 377f4a9 into main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get title of Image on URL and display on sidebar
1 participant