Add SSCS as scan type for the triage command (AST-72075) #1022
Conversation
cx-ruio
requested review from
AlvoBen,
greensd4 and
miryamfoiferCX
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Great job, no security vulnerabilities found in this Pull Request |
cx-ruio
force-pushed
the
feature/AST-72075-cli-add-sscs-as-scan-type-for-the-triage-command
branch
from
1a51196 to
c22a73a
Compare
| type ScanOverviewHTTPWrapper struct { | ||
| path string | ||
| } | ||
|
|
||
| func NewHTTPScanOverviewWrapper(path string) ScanOverviewWrapper { | ||
| validPath := configurePath(path) |
There was a problem hiding this comment.
The configurePath function is not defined within the provided diff. Ensure that the function exists and is properly implemented to handle the path parameter. If it's defined in another file, make sure it is correctly imported and accessible in this context.
| func TestWriteSingleConfigKeyStringNonExistingFile_CreatingTheFileAndWritesTheKey_Success(t *testing.T) { | ||
| configFilePath := "non-existing-file" | ||
|
|
||
| file, err := os.Open(configFilePath) |
There was a problem hiding this comment.
The file handle file is not closed after opening. Consider deferring the close operation immediately after checking the error from os.Open to avoid resource leaks.
cx-ruio
force-pushed
the
feature/AST-72075-cli-add-sscs-as-scan-type-for-the-triage-command
branch
from
86b550a to
2375f6f
Compare
|
|
||
| file, err = os.Open(configFilePath) | ||
| assert.NilError(t, err) | ||
| defer func(file *os.File) { |
There was a problem hiding this comment.
Use file.Close() and os.Remove(configFilePath) directly without the anonymous function wrapper since there's no additional logic that requires the use of defer in this context.
| func TestWriteSingleConfigKeyStringNonExistingFile_CreatingTheFileAndWritesTheKey_Success(t *testing.T) { | ||
| configFilePath := "non-existing-file" | ||
|
|
||
| file, err := os.Open(configFilePath) |
| file, err := os.Open(configFilePath) | ||
| asserts.NotNil(t, err) | ||
| asserts.Nil(t, file) | ||
| err = file.Close() |
There was a problem hiding this comment.
Attempting to close a file that failed to open is unnecessary and could lead to a nil pointer dereference. Remove the file.Close() call and the subsequent error check.
cx-ruio
force-pushed
the
feature/AST-72075-cli-add-sscs-as-scan-type-for-the-triage-command
branch
from
ed90b74 to
2375f6f
Compare
cx-ruio
force-pushed
the
feature/AST-72075-cli-add-sscs-as-scan-type-for-the-triage-command
branch
from
2375f6f to
0ade878
Compare
…for-the-triage-command
By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
References
Testing
Checklist