Skip to content

Commit

Permalink
Removed an assert that made the test suite fail without html5lib.
Browse files Browse the repository at this point in the history
Fixes nolanw#51.
Closes nolanw#54.
  • Loading branch information
zoul authored and nolanw committed Dec 16, 2015
1 parent 7d3c98b commit d54f1d9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ There are C libraries such as [Gumbo][] or [Hubbub][], but you need to shuffle d
## Does it work?
HTMLReader continually runs [html5lib][html5lib-tests]'s tokenization and tree construction tests, ignoring the tests for `<template>` (which HTMLReader does not implement).
HTMLReader continually runs [html5lib][html5lib-tests]'s tokenization and tree construction tests, ignoring the tests for `<template>` (which HTMLReader does not implement). Note that you need to check out the `Tests/html5lib` Git submodule in order to actually run these tests.
HTMLReader is continually tested on iOS versions 7.0, 7.1, and 8.1, as well as OS X versions 10.9 and 10.10. It should work on down to iOS 5 and OS X 10.7 but no automated testing is done.
Expand Down
4 changes: 3 additions & 1 deletion Tests/HTMLEncodingTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,9 @@ - (void)testEncodingDetection
includingPropertiesForKeys:nil
options:NSDirectoryEnumerationSkipsHiddenFiles
error:&error];
NSCAssert(candidates, @"possible error listing test directory: %@", error);
if (candidates == nil) {
NSLog(@"Cannot find the HTML5 tests, do you have the submodule (%@) checked out?", html5libTestPath());
}

// Skipping test-yahoo-jp.dat because I can't be bothered to figure out how it's encoded.
NSPredicate *predicate = [NSPredicate predicateWithFormat:@"pathExtension = 'dat' && lastPathComponent != 'test-yahoo-jp.dat'"];
Expand Down

0 comments on commit d54f1d9

Please sign in to comment.