Resolved invalid use of nullable values in tests

Added checks for `nil` before using values, then cast the values to `__nonnull` pointers.
ChatSecure · Nov 25, 2015 · b7d71c9 · b7d71c9
1 parent 911d6c2
commit b7d71c9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/Tests/HTMLSelectorTests.m b/Tests/HTMLSelectorTests.m
@@ -84,7 +84,10 @@ - (void)testNthParsing
     NSArray *nodes = [self.testDoc nodesMatchingSelector:(selectorString)]; \
     NSMutableArray *IDs = [NSMutableArray new]; \
     for (HTMLElement *node in nodes) { \
-        [IDs addObject:(node[@"id"] ?: node.tagName)]; \
+        id object = node[@"id"] ?: node.tagName; \
+        if (object) { \
+            [IDs addObject:(id __nonnull)object]; \
+        } \
     } \
     XCTAssertEqualObjects(IDs, expectedIDs); \
 } while(0)

diff --git a/Tests/HTMLTreeConstructionTests.m b/Tests/HTMLTreeConstructionTests.m
@@ -278,8 +278,9 @@ BOOL TreesAreTestEquivalent(id aThing, id bThing)
         if (![bThing isKindOfClass:[HTMLDocumentType class]]) return NO;
         HTMLDocumentType *a = aThing, *b = bThing;
         return (((a.name == nil && b.name == nil) || [a.name isEqualToString:b.name]) &&
-                [a.publicIdentifier isEqualToString:b.publicIdentifier] &&
-                [a.systemIdentifier isEqualToString:b.systemIdentifier]);
+                b.publicIdentifier != nil && b.systemIdentifier != nil &&
+                [a.publicIdentifier isEqualToString:(NSString * __nonnull)b.publicIdentifier] &&
+                [a.systemIdentifier isEqualToString:(NSString * __nonnull)b.systemIdentifier]);
     } else if (arrayLike(aThing)) {
         if (!arrayLike(bThing)) return NO;
         NSArray *a = aThing, *b = bThing;