A couple of small changes from Debian cdimage project #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path `/sbin` is not always included for $PATH for every system, for example the default Debian installation. To be safe, let's use full path `/sbin/blkid` instead. Signed-off-by: Shawn Guo <[email protected]>
Folder `/lib/firmware/ath10k/` defined by PATH_LIBFW_ATH10K doesn't exist for every system. To be safe, let's check its existence and create it if it doesn't exist. Signed-off-by: Shawn Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yoga_fw_extract.sh is very useful for aarch64-laptops debian-cdimage project to extract firmware files from Windows partition. We really appreciate the effort. This is a couple of small changes we made when using the script, and we would try to propose them for upstream inclusion. Thanks!