-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] API example for structured_state for upcoming release v0.6.0 #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked if everything is working?
Maybe it would be good to add the python only version from the notebooks as well?
Are you doing any CI checks for them?
I've checked the notebooks run fine on my personal laptop, which has NVIDIA GPUs.
Do you mean a version of the notebook without the result cells?
Our CI is very limited: since it's not setup on a computer with GPUs, CI does not run any automatic tests. This is far from ideal, and I'm hoping to get access to a cloud node with GPUs at some point in the future via AWS, or to set it up on a desktop the QEC team has given me access to. I'll work on this whenever some more people join the dev team. |
One of the problem with the ipynb files is that it is very difficult to compare them with older versions, we have solved this in the pytket examples in the way that we have the python version of the notebooks in the repo as well and check that they both match on the CI.
See https://github.com/CQCL/pytket-docs/blob/main/examples/check-examples#L19 If you think this would be helpful here as well, I am happy to add this here to the PR if you want to :) Not having a GPU on the CI is something we should try to solve maybe at a later point in time, I was not aware that is still missing... |
Ah! That sounds nice indeed. I think it'd be a good addition to this PR, thanks! :) |
@PabloAndresCQ I have added that now, feel free to take a look :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me.
I'll fix a small issue with the mps_tutorial
notebook due to an attached picture being lost in the refactor, and then we're good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! I've also verified that .py
files run with no issues on a computer with GPUs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for rescuing the image :)
Description
examples/mps_tutorial.ipynb
[view]examples/ttn_tutorial.ipynb
[view]Checklist