Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Always canonicalise MPS before 2q gate #82

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

PabloAndresCQ
Copy link
Collaborator

@PabloAndresCQ PabloAndresCQ commented Mar 4, 2024

We used to only canonicalise MPS when there was going to be a truncation. However, some experiments using Mekena's use case have shown that canonicalising is also beneficial for exact simulation. In hindsight, this makes sense since canonicalisation will often reduce bond dimension (thanks to reduced QR decomposition) which will in most cases accelerate the simulation more than what the overhead of canonicalisation imposes.

Checklist

  • I have run the tests on a machine with GPUs.
  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@PabloAndresCQ PabloAndresCQ requested a review from yapolyak March 4, 2024 14:02
@PabloAndresCQ PabloAndresCQ mentioned this pull request Mar 4, 2024
3 tasks
@PabloAndresCQ PabloAndresCQ mentioned this pull request Mar 19, 2024
5 tasks
@PabloAndresCQ PabloAndresCQ requested review from cqc-melf and removed request for yapolyak April 3, 2024 14:20
@PabloAndresCQ PabloAndresCQ changed the title Always canonicalise MPS before 2q gate [feature ] Always canonicalise MPS before 2q gate Apr 3, 2024
@PabloAndresCQ PabloAndresCQ changed the title [feature ] Always canonicalise MPS before 2q gate [feature] Always canonicalise MPS before 2q gate Apr 3, 2024
@PabloAndresCQ PabloAndresCQ merged commit aafd61d into develop Apr 3, 2024
6 checks passed
@PabloAndresCQ PabloAndresCQ deleted the feature/mps_always_canonicalise branch April 3, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants