[feature] Always canonicalise MPS before 2q gate #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to only canonicalise MPS when there was going to be a truncation. However, some experiments using Mekena's use case have shown that canonicalising is also beneficial for exact simulation. In hindsight, this makes sense since canonicalisation will often reduce bond dimension (thanks to reduced QR decomposition) which will in most cases accelerate the simulation more than what the overhead of canonicalisation imposes.
Checklist