Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain to pytket 1.x. #187

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Constrain to pytket 1.x. #187

merged 1 commit into from
Jan 28, 2025

Conversation

cqc-alec
Copy link
Collaborator

When we release pytket 2.0 the ClassicalExpBox and add_classicalexpbox_{bit,register} will disappear. After that it should be a simple matter to update the requirement to ">= 2.0.0" and remove the handling of, and tests involving, ClassicalExpBox in this repo.

@cqc-alec cqc-alec marked this pull request as ready for review January 28, 2025 12:51
@cqc-alec
Copy link
Collaborator Author

Not sure if the test failure is something to worry about or a statistical freak event -- does not seem related to this PR anyway.

Copy link
Collaborator

@PabloAndresCQ PabloAndresCQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test that failed checks that a distribution of shots matches the theory (with some loose threshold). Indeed, it was just a rare statistical failure.

@PabloAndresCQ PabloAndresCQ merged commit 48475f5 into main Jan 28, 2025
8 checks passed
@PabloAndresCQ PabloAndresCQ deleted the ae/clexpr branch January 28, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants