Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support general matrix elements in backend #128

Closed
wants to merge 5 commits into from

Conversation

obackhouse
Copy link
Collaborator

Description

Adds a function to CuTensorNetBackend to get general matrix elements. Expectation values are computed as a special case of that function.

I've not added tests as of now, as my understanding as per @PabloAndresCQ is that this is soon to be refactored anyway, so this PR may become defunct.

Related issues

Please mention any github issues addressed by this PR.

Checklist

  • I have run the tests on a device with GPUs.
  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

Copy link
Collaborator

@PabloAndresCQ PabloAndresCQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ollie. Just a couple of comments that might affect correctness of code that you write using this.

I'll leave this PR open until this feature is added using the new API.

@PabloAndresCQ
Copy link
Collaborator

@obackhouse is it OK to close this PR, since #165 should be providing what you need?

@obackhouse
Copy link
Collaborator Author

yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants