Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use pytket-docs-theming submodule #16

Merged
merged 9 commits into from
Oct 2, 2024
Merged

docs: Use pytket-docs-theming submodule #16

merged 9 commits into from
Oct 2, 2024

Conversation

CalMacCQ
Copy link
Contributor

@CalMacCQ CalMacCQ commented Oct 1, 2024

Description

The docs C.I. build still needs to be updated

I've verified that the docs build works locally.

Related issues

Please mention any github issues addressed by this PR.

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@CalMacCQ CalMacCQ requested a review from cqc-alec as a code owner October 1, 2024 16:12
@CalMacCQ CalMacCQ requested a review from cqc-melf October 1, 2024 16:15
@CalMacCQ CalMacCQ marked this pull request as draft October 1, 2024 16:15
@CalMacCQ CalMacCQ changed the title Docs/new theme docs: Use pytket-docs-theming submodule Oct 1, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is called from the CI:

run: ./.github/workflows/docs/check-build-docs

It would be good to continue testing the docs build on the CI if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah sorry I was going to update the C.I. to match what is in this PR
CQCL/pytket-qiskit#392

We will continue to run the docs build in C.I.

@cqc-melf
Copy link
Collaborator

cqc-melf commented Oct 2, 2024

@CalMacCQ is this now ready for review?

@CalMacCQ CalMacCQ marked this pull request as ready for review October 2, 2024 15:06
@CalMacCQ
Copy link
Contributor Author

CalMacCQ commented Oct 2, 2024

Is this build failure expected?

@cqc-alec
Copy link
Collaborator

cqc-alec commented Oct 2, 2024

Is this build failure expected?

Yes.

@cqc-alec cqc-alec merged commit e8462af into main Oct 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants