build: Fix -Wformat warnings #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this include statement, both GCC and clang fails building, giving "incomplete type" errors.
This method can be used instead of doing `static_cast<const char*>` every time it is needed.
Some Linux distros uses `-Wformat -Werror=format-security` flags when building C/C++ projects by default. This makes harder to build Lampray on such distros with default build flags.
|
I had to include changes from #118 to be able test changes locally, then this should be merged after #118 (and may require a rebase) Also I encountered this issue when I was trying to create a PKGBUILD file for Arch User Repository ( https://aur.archlinux.org/packages/lampray ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Linux distros uses
-Wformat -Werror=format-securityflags whenbuilding C/C++ projects by default. This makes harder to build Lampray
on such distros with default build flags.