-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Decompile button to network page #174
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @portdeveloper really love the idea! and good looks good too!
Some changes on UI :
- Can we have the button loading state similar to Decompile button on home page?
- Maybe instead of adding the whole paragraph for decompile what if we just have the heading and the button, I think it should be just fine and looks a bit clean? Since anywhich ways we are not explaining decompile feature in home page too. Also it adds differentiation b/w add Abi manually and Decompile ABi
Cc @Pabl0cks once for this UI suggestions 🙌 But also not strong opinion on any of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TYSM for tackling this Port! GJ 🙌
I've added a comment with a problem when loading "regular" contracts, that should show contract data directly from etherscan.
I like Shiv's UI suggestions! For the second suggestion I prefer the option with the button at the left, since in very wide screens the button will be really far away from the title. We could also tweak the page description a bit after this UI change, to something like this:
|
Thanks! Will check soon, looks like i have missed some critical problems there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now is looking good to me! TYSM @portdeveloper !! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working great! Thanks @portdeveloper and @Pabl0cks suggestions 🙌
Description
This PR adds a "Decompile button to the [network].tsx page which enables decompilations on that page.
msedge_XibkG3nrC6.mp4