Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Decompile button to network page #174

Merged
merged 5 commits into from
Feb 17, 2025

Conversation

portdeveloper
Copy link
Member

Description

This PR adds a "Decompile button to the [network].tsx page which enables decompilations on that page.

msedge_XibkG3nrC6.mp4

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abi-ninja-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 7:23am

Copy link
Member

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @portdeveloper really love the idea! and good looks good too!

Some changes on UI :

  1. Can we have the button loading state similar to Decompile button on home page?

Screenshot 2025-02-14 at 1 03 24 PM

  1. Maybe instead of adding the whole paragraph for decompile what if we just have the heading and the button, I think it should be just fine and looks a bit clean? Since anywhich ways we are not explaining decompile feature in home page too. Also it adds differentiation b/w add Abi manually and Decompile ABi

Screenshot 2025-02-14 at 1 07 23 PM

or both buttons at the right

Screenshot 2025-02-14 at 1 14 26 PM

Cc @Pabl0cks once for this UI suggestions 🙌 But also not strong opinion on any of this

Copy link
Member

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM for tackling this Port! GJ 🙌

I've added a comment with a problem when loading "regular" contracts, that should show contract data directly from etherscan.

@Pabl0cks
Copy link
Member

Some changes on UI :

I like Shiv's UI suggestions! For the second suggestion I prefer the option with the button at the left, since in very wide screens the button will be really far away from the title.

We could also tweak the page description a bit after this UI change, to something like this:

<p className="pb-2">
  Make sure the data is correct and you are connected to the right network. You can also import the
  ABI manually, or decompile the contract (beta).
</p>

@portdeveloper
Copy link
Member Author

Thanks! Will check soon, looks like i have missed some critical problems there

Copy link
Member

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now is looking good to me! TYSM @portdeveloper !! 🙏

Copy link
Member

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great! Thanks @portdeveloper and @Pabl0cks suggestions 🙌

@technophile-04 technophile-04 merged commit 598f932 into main Feb 17, 2025
4 checks passed
carletex pushed a commit that referenced this pull request Feb 17, 2025
carletex pushed a commit that referenced this pull request Feb 17, 2025
carletex pushed a commit that referenced this pull request Feb 17, 2025
carletex pushed a commit that referenced this pull request Feb 17, 2025
carletex pushed a commit that referenced this pull request Feb 17, 2025
@portdeveloper portdeveloper deleted the fix/decompile-contract-on-refresh branch February 18, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants