Validate datasource setting on components #15414
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
There was a problem hiding this comment.
This LGTM - but I'll leave @aptkingston to comment as well - given it crosses the builder/client boundary!
adrinr
added
the
do not merge
There was a problem hiding this comment.
Nice work @adrinr! Glad this approach worked out 👌 Mostly just a few opinions here - nothing major other than just being aware that this currently wouldn't support component plugins, which is probably fine.
|
|
||
| recurseFieldComponentsInChildren(screen?.props, type) | ||
| return result | ||
| } |
There was a problem hiding this comment.
This doesn't account for custom components, which are stored separately, but that's probably fine. Just as long as it's a known limitation
There was a problem hiding this comment.
I will create a ticket for a "nice to have", and to tackle this if we have some extra time
|
Found an issue that causes the component to render to a frame with the wrong data, calling the API with the invalid data. This displays an unexpected error notification. Investigating why |
Solved |
Description
Validate "table" settings on components. This is used in the components
form block,multistep form blockandrow explorer. If the set table/view does not exist anymore, we will display a friendly error instead of a confusing error.Screenshots
Previous
New behaviour
Launchcontrol
Improve verbosity for wrong datasource settings values