Introduce HashMap for Symbol Table Management

[SIGMazer]

Description

• Replaced the existing symbol table implementation with a HashMap for faster lookups.
• Updated all functions interacting with symbol_table to accommodate the new HashMap structure.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update
• Performance improvement

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have documented my changes in the code or documentation
• I have added tests that prove my changes work (if applicable)
• All new and existing tests pass

[araujo88]

I've made a hashmap lib in C a while ago, might give it a shot? https://github.com/araujo88/chashmap

[SIGMazer]

I've made a hashmap lib in C a while ago, might give it a shot? https://github.com/araujo88/chashmap

sure

[araujo88]

I've made a hashmap lib in C a while ago, might give it a shot? https://github.com/araujo88/chashmap

sure

from what I've seen, the implementation is similar. We just have to make sure that it is as safe as possible and avoid memory leaks. Perhaps running some tests with valgrind?

[SIGMazer]

I've made a hashmap lib in C a while ago, might give it a shot? https://github.com/araujo88/chashmap

sure

from what I've seen, the implementation is similar. We just have to make sure that it is as safe as possible and avoid memory leaks. Perhaps running some tests with valgrind?

i checked it and i found set variables function leaks memory and i fix it in last commit but also create_node some how leak memory and i cannot get the cause

==709571== 224 bytes in 4 blocks are definitely lost in loss record 62 of 71
==709571==    at 0x484280F: malloc (vg_replace_malloc.c:442)
==709571==    by 0x4066F5: create_node (in /home/sigmazer/projects/brainrot/brainrot)
==709571==    by 0x4067AA: create_int_node (in /home/sigmazer/projects/brainrot/brainrot)
==709571==    by 0x402C0B: yyparse (in /home/sigmazer/projects/brainrot/brainrot)
==709571==    by 0x403535: main (in /home/sigmazer/projects/brainrot/brainrot)

[araujo88]

I've made a hashmap lib in C a while ago, might give it a shot? https://github.com/araujo88/chashmap

sure

from what I've seen, the implementation is similar. We just have to make sure that it is as safe as possible and avoid memory leaks. Perhaps running some tests with valgrind?

i checked it and i found set variables function leaks memory and i fix it in last commit but also create_node some how leak memory and i cannot get the cause

==709571== 224 bytes in 4 blocks are definitely lost in loss record 62 of 71
==709571==    at 0x484280F: malloc (vg_replace_malloc.c:442)
==709571==    by 0x4066F5: create_node (in /home/sigmazer/projects/brainrot/brainrot)
==709571==    by 0x4067AA: create_int_node (in /home/sigmazer/projects/brainrot/brainrot)
==709571==    by 0x402C0B: yyparse (in /home/sigmazer/projects/brainrot/brainrot)
==709571==    by 0x403535: main (in /home/sigmazer/projects/brainrot/brainrot)

I was thinking of adding a valgrind check to the CI. It would run on every test we have. What do you think?

[SIGMazer]

That will be nice

[SIGMazer]

I've made a hashmap lib in C a while ago, might give it a shot? https://github.com/araujo88/chashmap

sure

from what I've seen, the implementation is similar. We just have to make sure that it is as safe as possible and avoid memory leaks. Perhaps running some tests with valgrind?

i checked it and i found set variables function leaks memory and i fix it in last commit but also create_node some how leak memory and i cannot get the cause

==709571== 224 bytes in 4 blocks are definitely lost in loss record 62 of 71
==709571==    at 0x484280F: malloc (vg_replace_malloc.c:442)
==709571==    by 0x4066F5: create_node (in /home/sigmazer/projects/brainrot/brainrot)
==709571==    by 0x4067AA: create_int_node (in /home/sigmazer/projects/brainrot/brainrot)
==709571==    by 0x402C0B: yyparse (in /home/sigmazer/projects/brainrot/brainrot)
==709571==    by 0x403535: main (in /home/sigmazer/projects/brainrot/brainrot)

I was thinking of adding a valgrind check to the CI. It would run on every test we have. What do you think?

will we fix the memory leaks in this pr or merge it and make a new one with valgrind check?

[araujo88]

I've made a hashmap lib in C a while ago, might give it a shot? https://github.com/araujo88/chashmap

sure

from what I've seen, the implementation is similar. We just have to make sure that it is as safe as possible and avoid memory leaks. Perhaps running some tests with valgrind?

i checked it and i found set variables function leaks memory and i fix it in last commit but also create_node some how leak memory and i cannot get the cause

==709571== 224 bytes in 4 blocks are definitely lost in loss record 62 of 71
==709571==    at 0x484280F: malloc (vg_replace_malloc.c:442)
==709571==    by 0x4066F5: create_node (in /home/sigmazer/projects/brainrot/brainrot)
==709571==    by 0x4067AA: create_int_node (in /home/sigmazer/projects/brainrot/brainrot)
==709571==    by 0x402C0B: yyparse (in /home/sigmazer/projects/brainrot/brainrot)
==709571==    by 0x403535: main (in /home/sigmazer/projects/brainrot/brainrot)

I was thinking of adding a valgrind check to the CI. It would run on every test we have. What do you think?

will we fix the memory leaks in this pr or merge it and make a new one with valgrind check?

I think fixing the memory leaks would be beyond the scope of this PR. We can merge as it is and then tackle the memory leaks in a separate PR. I'll create a PR adding a memory management lib.