Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cooked giga and thicc up #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dominik-air
Copy link

Description

Related Issue

Resolves #99

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Performance improvement
  • Refactor

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have documented my changes in the code or documentation
  • I have added tests that prove my changes work (if applicable)
  • I have run the unit tests locally
  • I have run the valgrind memory tests locally
  • All new and existing tests pass

@dominik-air dominik-air marked this pull request as draft February 12, 2025 23:01
@araujo88
Copy link
Member

You implemented long and long long as integer types, when they are actually a type modifier. You can have a long double or long long double for example. long float and long long float are not valid types.

@SIGMazer SIGMazer marked this pull request as ready for review February 13, 2025 05:42
@dominik-air
Copy link
Author

lil-yachty-drake

My bad. Gonna rework this no cap

@araujo88
Copy link
Member

Take your time to cook, no rush. And thanks for being willing to grind like a true sigma. Reach out on Discord if you need some guidance on this issue.

@araujo88 araujo88 added the enhancement New feature or request label Feb 13, 2025
@dominik-air dominik-air force-pushed the feat/implement-giga-and-thicc branch from a9037a8 to f49245a Compare February 13, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for other type modifiers
2 participants