Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle arrays with one pointer #113

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Handle arrays with one pointer #113

merged 1 commit into from
Feb 1, 2025

Conversation

SIGMazer
Copy link
Contributor

@SIGMazer SIGMazer commented Jan 30, 2025

Description

Refactoring all arrays types iarray, farray,...etc to a void pointer array_data.

Related Issue

Fixes #<issue_number>

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Performance improvement
  • Refactor

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have documented my changes in the code or documentation
  • I have added tests that prove my changes work (if applicable)
  • I have run the unit tests locally
  • I have run the valgrind memory tests locally
  • All new and existing tests pass

@SIGMazer SIGMazer requested a review from araujo88 as a code owner January 30, 2025 17:42
@araujo88
Copy link
Member

Can you elaborate a bit more on what this PR is doing? I've seen you removed a lot of code, making it cleaner.

@SIGMazer SIGMazer merged commit ab06d25 into main Feb 1, 2025
2 checks passed
@SIGMazer SIGMazer deleted the refactor/arrays branch February 1, 2025 03:06
@araujo88 araujo88 added the refactor Modify existing working code but keeping the same functionality. label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Modify existing working code but keeping the same functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants