Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add test cases for slorp #108

Merged
merged 3 commits into from
Feb 1, 2025
Merged

Conversation

araujo88
Copy link
Member

@araujo88 araujo88 commented Jan 25, 2025

Description

Fix: add test cases for slorp. WAIT BEFORE MERGING

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Performance improvement
  • Refactor

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have documented my changes in the code or documentation
  • I have added tests that prove my changes work (if applicable)
  • I have run the unit tests locally
  • I have run the valgrind memory tests locally
  • All new and existing tests pass

@araujo88 araujo88 requested a review from SIGMazer as a code owner January 25, 2025 19:20
@araujo88
Copy link
Member Author

The following cases are raising error:

[leonardo@archlinux brainrot]$ ./brainrot test_cases/slorp_char.brainrot 
c
Error: Invalid integer format.
[leonardo@archlinux brainrot]$ ./brainrot test_cases/slorp_string.brainrot 
bloat
Error reading char: -3

Still trying to figure out why.

@araujo88 araujo88 added help wanted Extra attention is needed tests Testing examples and edge cases bugfix Fix for something that wasn't working labels Jan 25, 2025
@SIGMazer
Copy link
Contributor

@araujo88 we need a better way to handle strings variables

@SIGMazer
Copy link
Contributor

can you check the memory leaks

@araujo88
Copy link
Member Author

can you check the memory leaks

Yes, I'll take a look.

@araujo88
Copy link
Member Author

We have some warnings by bison of counter examples in the parser.

@SIGMazer
Copy link
Contributor

We have some warnings by bison of counter examples in the parser.

we can resolve the warnings in this PR #105

@araujo88 araujo88 merged commit 651696b into main Feb 1, 2025
1 of 2 checks passed
@araujo88 araujo88 deleted the fix/add-test-cases-for-slorp branch February 1, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix for something that wasn't working help wanted Extra attention is needed tests Testing examples and edge cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants