Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARQLStore specialization #360

Merged
merged 42 commits into from
Nov 27, 2023
Merged

SPARQLStore specialization #360

merged 42 commits into from
Nov 27, 2023

Conversation

crisely09
Copy link
Contributor

@crisely09 crisely09 commented Nov 22, 2023

Adding a SPARQL specialization of a DatasetStore, built on top of #353

  • Missing more unit tests
  • Missing other tests for particular database examples
  • Changes here should be merged with Sarah's code to unify the SPARQL modules and methods.

setup.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Attention: 176 lines in your changes are missing coverage. Please review.

Comparison is base (4952365) 74.48% compared to head (bd16254) 74.42%.

Files Patch % Lines
kgforge/core/archetypes/read_only_store.py 49.47% 48 Missing ⚠️
kgforge/core/archetypes/dataset_store.py 51.31% 37 Missing ⚠️
kgforge/specializations/stores/bluebrain_nexus.py 40.42% 28 Missing ⚠️
kgforge/specializations/stores/sparql_store.py 64.55% 28 Missing ⚠️
kgforge/core/commons/sparql_query_builder.py 92.47% 7 Missing ⚠️
kgforge/core/archetypes/store.py 79.16% 5 Missing ⚠️
kgforge/core/commons/es_query_builder.py 37.50% 5 Missing ⚠️
kgforge/core/forge.py 58.33% 5 Missing ⚠️
kgforge/core/commons/execution.py 42.85% 4 Missing ⚠️
kgforge/core/commons/query_builder.py 60.00% 4 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
- Coverage   74.48%   74.42%   -0.06%     
==========================================
  Files          93      100       +7     
  Lines        5894     6213     +319     
==========================================
+ Hits         4390     4624     +234     
- Misses       1504     1589      +85     
Flag Coverage Δ
unittests 74.42% <69.65%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crisely09 crisely09 requested a review from ssssarah November 27, 2023 09:18
@crisely09 crisely09 merged commit 4d2580e into master Nov 27, 2023
1 check passed
@crisely09 crisely09 deleted the dev-sparql branch November 27, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants