Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prepare uri when deprecating resources #358

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

ssssarah
Copy link
Contributor

@ssssarah ssssarah commented Nov 21, 2023

Extends this MR, for the deprecation of schemas

@ssssarah ssssarah requested a review from MFSY November 21, 2023 17:24
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9ffefac) 74.13% compared to head (a577397) 74.09%.

Files Patch % Lines
kgforge/specializations/stores/bluebrain_nexus.py 0.00% 4 Missing ⚠️
kgforge/specializations/stores/nexus/service.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
- Coverage   74.13%   74.09%   -0.04%     
==========================================
  Files          93       93              
  Lines        5919     5922       +3     
==========================================
  Hits         4388     4388              
- Misses       1531     1534       +3     
Flag Coverage Δ
unittests 74.09% <25.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssssarah ssssarah self-assigned this Nov 22, 2023
@ssssarah ssssarah merged commit 4952365 into master Nov 22, 2023
@ssssarah ssssarah deleted the provide_schema_id_on_deprecate branch November 22, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants