Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add an auto_format parameter to the ValidationResultSet constructor #62

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

adrien-berchet
Copy link
Member

Description

Pandas==2.2.2 changed some call orders that result in a RecursionError in some cases. To make things simpler the format_data() method must now be explicitly called.

Checklist

This pull request is:

  • A documentation / typographical error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • Please include: Fixes: #<issue number> in the description if it solves an existing issue
      (which must include a complete example of the issue).
    • Please include tests that fail with the main branch and pass with the provided fix.
  • A new feature implementation or update an existing feature
    • Please include: Fixes: #<issue number> in the description if it solves an existing issue
      (which must include a complete example of the feature).
    • Please include tests that cover every lines of the new/updated feature.
    • Please update the documentation to describe the new/updated feature.

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (08dfd07) to head (4727c8e).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #62   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          730       729    -1     
  Branches       143       143           
=========================================
- Hits           730       729    -1     
Flag Coverage Δ
pytest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
data_validation_framework/result.py 100.00% <100.00%> (ø)
data_validation_framework/task.py 100.00% <100.00%> (ø)

@adrien-berchet adrien-berchet merged commit 7a49424 into main Apr 26, 2024
7 checks passed
@adrien-berchet adrien-berchet deleted the recursive_error_pd_2.2.2 branch April 26, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants