Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow stimuli to be non-threshold based #83

Merged
merged 2 commits into from
Nov 20, 2023
Merged

allow stimuli to be non-threshold based #83

merged 2 commits into from
Nov 20, 2023

Conversation

AurelienJaquier
Copy link
Collaborator

No description provided.

Change-Id: I567c95a3561882af1282d1e4631a1a28199340fb
@AurelienJaquier AurelienJaquier self-assigned this Nov 20, 2023
Change-Id: I9ddf40394c07a07bc7cbbd77423cc9cf881e373a
@AurelienJaquier AurelienJaquier marked this pull request as ready for review November 20, 2023 16:01
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2bea553) 60.67% compared to head (f89d62a) 61.31%.

Files Patch % Lines
bluepyemodel/ecode/random_square_inputs.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   60.67%   61.31%   +0.64%     
==========================================
  Files          96       96              
  Lines        6476     6586     +110     
==========================================
+ Hits         3929     4038     +109     
- Misses       2547     2548       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AurelienJaquier AurelienJaquier merged commit 90354f8 into main Nov 20, 2023
6 checks passed
@AurelienJaquier AurelienJaquier deleted the ecode-fix branch November 20, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants