Support greedy addressees #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgriffiths
reviewed
Apr 23, 2021
src/ga_tx.cpp
Outdated
| // No need for implicit change output | ||
| continue; | ||
| } | ||
|
|
There was a problem hiding this comment.
At 792 we should add the dust to an explicit change output if there is one.
I think we also need a check that if any outputs are marked is_change then the tx has no added change output already.
There was a problem hiding this comment.
I've moved this logic around a bit so that now any dust will be added to the greedy addressee before being considered for change.
Logic should be such that there won't be a change output if there is a greedy one.
jkauffman1
force-pushed
the
explicit-change
branch
2 times, most recently
from
5f678ac to
8d74316
Compare
jkauffman1
force-pushed
the
explicit-change
branch
4 times, most recently
from
5b57e2c to
bf41f83
Compare
jkauffman1
force-pushed
the
explicit-change
branch
4 times, most recently
from
fc05354 to
1d97818
Compare
jkauffman1
force-pushed
the
explicit-change
branch
from
1d97818 to
bae239e
Compare
jkauffman1
force-pushed
the
explicit-change
branch
from
bae239e to
26427ca
Compare
jgriffiths
reviewed
Feb 24, 2022
src/ga_tx.cpp
Outdated
| for (auto& addressee : *addressees_p) { | ||
| const auto addressee_asset_id = asset_id_from_json(net_params, addressee); | ||
| if (addressee_asset_id == asset_id) { | ||
| required_total += add_tx_addressee(session, net_params, result, tx, addressee); | ||
| reordered_addressees.push_back(addressee); | ||
| if (addressee.value("greedy", false)) { |
There was a problem hiding this comment.
booleans in json should be named is_xxx, has_xxx etc.
There is no check here for multiple greedy outputs, should that error?
There was a problem hiding this comment.
Changed to is_greedy
jkauffman1
force-pushed
the
explicit-change
branch
from
26427ca to
3881e9e
Compare
Setting the 'greedy' flag on an addressee means it will consume any change instead of it going to a change output.
jkauffman1
force-pushed
the
explicit-change
branch
from
3881e9e to
d74f723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the 'greedy' flag on an addressee means it will consume any change instead of it going to a change output.