Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: time 0.3.34 -> 0.3.36 to support latest rustc stable #109

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

phlip9
Copy link

@phlip9 phlip9 commented Sep 17, 2024

The most recent stable compilers (1.79+) fail with "type annotations needed" when compiling the time crate with version <= 0.3.35:

$ cargo +1.80.1 check
# ...
error[E0282]: type annotations needed for `Box<_>`
  --> /Users/phlip9/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.34/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

    Checking hyperlocal v0.8.0
For more information about this error, try `rustc --explain E0282`.
error: could not compile `time` (lib) due to 1 previous error

This diff updates the time crate v0.3.34 -> v0.3.36 so we can compile with the latest stable compiler.

You can also reproduce this update with:

$ cargo +1.80.1 update -p [email protected] --precise 0.3.36
    Updating crates.io index
    Updating time v0.3.34 -> v0.3.36
    Updating time-macros v0.2.17 -> v0.2.18

The most recent stable compilers (1.79+) fail with "type annotations needed"
when compiling the `time` crate with version <= 0.3.35
@phlip9
Copy link
Author

phlip9 commented Sep 17, 2024

cc @RCasatta

Copy link
Collaborator

@RCasatta RCasatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 891426a

@RCasatta RCasatta merged commit 891426a into Blockstream:new-index Sep 17, 2024
2 checks passed
@phlip9 phlip9 deleted the phlip9/update-time-crate branch September 18, 2024 00:02
MaxFangX pushed a commit to lexe-app/lexe-public that referenced this pull request Oct 15, 2024
phlip9 added a commit to lexe-app/lexe-public that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants