Flake #54
Draft
Flake #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to create mock servers by the tests, not for the public registry API. The previous rocket release no longer works with recent versions of Rust, which broke the tests.
- rust-element now provides a ContractHash implementation that matches and replaces our contract_json_hash() - Add OutPointSerializer for compatibility with the existing registry db JSON file format - Switch to new hex traits, avoid unnecessary manual conversions - Drop direct dependency on the bitcoin_hashes & secp256k1 crates, use via the bitcoin crate instead - Fix deprecations for rust-secp256k1 v0.28
For integration testing using regtest the domain verification can be skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #52 and #53
flake to build the binaries, useful for integration testing in other projects