Updated `Payments` > `Requesting` page #651

Bosch-0 · 2022-02-10T10:51:23Z

Closes #641
Closes #640
Closes #663
Closes #653

Added a lot more detail around adding amounts to payment requests
Added a lot more detail around invoice expirations taking heavily from @sbddesign article.
Updated some images / other minor copy changes.

GBKS

Good additions, just had some comments. Main thing is that this page is getting really bulky. I'd address this by focusing the page more on UX and less on technical explanations, which can be moved to sub-pages. Better to have a page that makes it easy to parse and get the main steps of the flow, with plenty of options to dig deeper into the parts the reader is interested in.

As mentioned in the comments, I also recommend moving the Home screen image further up, before that design is referenced in the page copy.

I noticed a broken image reference further down the page. Github wouldn't let me add a comment to that line (page too long for the Github review screen). Look for [email protected].

There are 464 words on invoice expirations, I think that warrants a dedicated page. Could be a separate PR.

guide/payments/request.md

Co-authored-by: Christoph Ono <[email protected]>

pavlenex

Great works 🚀 left a few minor comments. Also there's a conflict with cached image that should be resolved.

guide/payments/request.md

pavlenex · 2022-02-18T08:46:09Z

guide/payments/request.md

+Several not widely supported reusable payments request formats exist. For Lightning, there are [BOLT12 offers](https://bolt12.org/) and AMP invoices.
+
+On-chain there are reusable payment codes [BIP 47](https://bips.xyz/47) and [xpubs]({{ "/guide/glossary/#extended-public-key-xpub-ypub-zpub" | relative_url }}), which can be used to generate addresses for receiving bitcoin on-chain. Standard addresses can be used but this is advised against due to [privacy concerns]({{ "/guide/payments/privacy/#generate-a-new-address-for-each-on-chain-payment" | relative_url }}). Learn more about these on our [payment request formats]({{ "/guide/payments/request/payment-request-formats/" | relative_url }}) page.
+
 ## Withdrawal request

 Another way a user can request bitcoin is from a withdrawal request. A withdrawal request is a payment request that lets the receiver withdraw bitcoin from another wallet. Unlike previously mentioned payment requests, withdrawal requests are generated by the sender. These can be useful for merchants providing refunds to customers.


I don't think you're requesting bitcoin, rather it's a way to receive it as it's not an action initiated by the received, it's sender that has to create this request for receiver to withdraw, right?

Suggested change

Another way a user can request bitcoin is from a withdrawal request. A withdrawal request is a payment request that lets the receiver withdraw bitcoin from another wallet. Unlike previously mentioned payment requests, withdrawal requests are generated by the sender. These can be useful for merchants providing refunds to customers.

Another way a user can receive bitcoin is from a withdrawal request. A withdrawal request is a payment request that lets the receiver withdraw bitcoin from another wallet. Unlike previously mentioned payment requests, withdrawal requests are generated by the sender. These can be useful for merchants providing refunds to customers.

Yeah very true! Probably having generating on of these should also be covered in the sending section.

I've discussed with @GBKS about also having a Receiving page that covers receiving in more detail (mostly LSP stuff) which we could move this part of the page too also

Are withdrawals only an LNURL thing or will BOLT 12 also make this possible?

In a way, this is initiated by the receiver. Let's say you deposit 100 sats in some Lightning app, take some actions, and then later want to withdraw your balance. Via LNURL-Withdraw, the app can have a static QR code on your profile that lets you withdraw whenever you want. So the sender still has to make the functionality available, but the receiver initiates the actual payment/withdrawal.

Co-authored-by: Pavlenex <[email protected]>

GBKS

Great update. Just had some minor nitpicks in a few places.

guide/payments/request.md

GBKS · 2022-02-21T09:27:29Z

guide/payments/request.md

+Several not widely supported reusable payments request formats exist. For Lightning, there are [BOLT12 offers](https://bolt12.org/) and AMP invoices.
+
+On-chain there are reusable payment codes [BIP 47](https://bips.xyz/47) and [xpubs]({{ "/guide/glossary/#extended-public-key-xpub-ypub-zpub" | relative_url }}), which can be used to generate addresses for receiving bitcoin on-chain. Standard addresses can be used but this is advised against due to [privacy concerns]({{ "/guide/payments/privacy/#generate-a-new-address-for-each-on-chain-payment" | relative_url }}). Learn more about these on our [payment request formats]({{ "/guide/payments/request/payment-request-formats/" | relative_url }}) page.
+
 ## Withdrawal request

 Another way a user can request bitcoin is from a withdrawal request. A withdrawal request is a payment request that lets the receiver withdraw bitcoin from another wallet. Unlike previously mentioned payment requests, withdrawal requests are generated by the sender. These can be useful for merchants providing refunds to customers.


Are withdrawals only an LNURL thing or will BOLT 12 also make this possible?

In a way, this is initiated by the receiver. Let's say you deposit 100 sats in some Lightning app, take some actions, and then later want to withdraw your balance. Via LNURL-Withdraw, the app can have a static QR code on your profile that lets you withdraw whenever you want. So the sender still has to make the functionality available, but the receiver initiates the actual payment/withdrawal.

guide/payments/request.md

Co-authored-by: Christoph Ono <[email protected]>

sbddesign

Looking good, I love the QR code updates.

My main issue is the part about expiries. While I agree with the information, I think it is presented in a way that is a little difficult to parse the context of these payment situations. Also, I appreciate the link to my blog post, but I don't know if that's necessary in this situation. I added a suggested rewrite to address all this.

guide/payments/request.md

Co-authored-by: Stephen DeLorme <[email protected]>

guide/payments/request.md

GBKS · 2022-03-04T11:05:05Z

Just did another review. Looks really good.

I think we discussed this before, but the page is really long. We should split out "Receiving bitcoin" to a dedicated page, which would then allow us to go more in-depth on that aspect. Also think we need to do a light revision for consistency once this PR and the one for the Activity page are merged.

Bosch-0 · 2022-03-05T05:21:41Z

We should split out "Receiving bitcoin" to a dedicated page

Yep agree, I'll get the LSP page done and then we can get on to that as I think it'll reference it quite a bit

sbddesign

Looking good. I echo the sentiments that the page is getting kind of long and it might be worth breaking out into subpages. That could be handled in another PR. Open to discussion. But in terms of content, I approve.

pavlenex

Awesome work, really in-depth and I really like the structure. Agreed with others that we potentially should think about breaking this down into smaller sections, but for now, it looks good to go, LFG 🚀

pavlenex · 2022-03-07T08:58:13Z

think we discussed this before, but the page is really long. We should split out "Receiving bitcoin" to a dedicated page, which would then allow us to go more in-depth on that aspect. Also think we need to do a light revision for consistency once this PR and the one for the Activity page are merged.

Agreed, now that this and activity page pr are merged, do you want to open up an issue so we can do the cleanup on what's needed?

Updated payments page.

ee55475

Bosch-0 added Payments Copy Task is about improving text. labels Feb 10, 2022

GBKS requested changes Feb 14, 2022

View reviewed changes

Bosch-0 and others added 2 commits February 14, 2022 19:09

Update guide/payments/request.md

ce47699

Co-authored-by: Christoph Ono <[email protected]>

Update guide/payments/request.md

7d1c776

Co-authored-by: Christoph Ono <[email protected]>

Bosch-0 added this to the Milestone #13: Lightning refinements milestone Feb 17, 2022

More updates.

80483f9

Bosch-0 requested review from GBKS, sbddesign, danielnordh, johnsBeharry, moneyball and pavlenex February 17, 2022 15:02

pavlenex reviewed Feb 18, 2022

View reviewed changes

Update guide/payments/request.md

459f1eb

Co-authored-by: Pavlenex <[email protected]>

GBKS requested changes Feb 21, 2022

View reviewed changes

Bosch-0 and others added 13 commits February 21, 2022 18:21

Update guide/payments/request.md

deb9ec4

Co-authored-by: Christoph Ono <[email protected]>

Update guide/payments/request.md

18c5b25

Co-authored-by: Christoph Ono <[email protected]>

Update guide/payments/request.md

55239f1

Co-authored-by: Christoph Ono <[email protected]>

Update guide/payments/request.md

345e2d8

Co-authored-by: Christoph Ono <[email protected]>

Update guide/payments/request.md

01d5a54

Co-authored-by: Christoph Ono <[email protected]>

Update guide/payments/request.md

686a804

Co-authored-by: Christoph Ono <[email protected]>

Update guide/payments/request.md

3e13289

Co-authored-by: Christoph Ono <[email protected]>

Update guide/payments/request.md

52d01c4

Co-authored-by: Christoph Ono <[email protected]>

Update guide/payments/request.md

14c1004

Co-authored-by: Christoph Ono <[email protected]>

Update guide/payments/request.md

125721f

Co-authored-by: Christoph Ono <[email protected]>

Update guide/payments/request.md

aa90e28

Co-authored-by: Christoph Ono <[email protected]>

Update guide/payments/request.md

4119bb9

Co-authored-by: Christoph Ono <[email protected]>

Feedback updates.

6a36bc1

Bosch-0 requested review from GBKS and pavlenex February 21, 2022 10:52

Bosch-0 added 2 commits February 21, 2022 20:00

Small typo.

74706d8

Fixed conflict.

6fc55bd

sbddesign requested changes Feb 21, 2022

View reviewed changes

GBKS previously approved these changes Feb 23, 2022

View reviewed changes

GBKS assigned Bosch-0 Feb 24, 2022

Bosch-0 dismissed GBKS’s stale review via 0044422 March 2, 2022 06:15

Bosch-0 and others added 2 commits March 2, 2022 14:15

Update guide/payments/request.md

0044422

Co-authored-by: Stephen DeLorme <[email protected]>

Update guide/payments/request.md

0acab85

Co-authored-by: Stephen DeLorme <[email protected]>

Bosch-0 commented Mar 2, 2022

View reviewed changes

guide/payments/request.md Outdated Show resolved Hide resolved

Bosch-0 and others added 2 commits March 2, 2022 14:22

Update guide/payments/request.md

0e0ba5a

Merge remote-tracking branch 'upstream/master' into invoice-patch

f5009ca

GBKS reviewed Mar 4, 2022

View reviewed changes

guide/payments/request.md Outdated Show resolved Hide resolved

Feedback updates.

28f7bab

sbddesign previously approved these changes Mar 5, 2022

View reviewed changes

Fixed conflict.

c6c22ca

Bosch-0 dismissed sbddesign’s stale review via c6c22ca March 5, 2022 23:55

Bosch-0 requested review from GBKS and sbddesign March 6, 2022 00:00

pavlenex approved these changes Mar 7, 2022

View reviewed changes

pavlenex merged commit 6c60bdc into BitcoinDesign:master Mar 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated `Payments` > `Requesting` page #651

Updated `Payments` > `Requesting` page #651

Bosch-0 commented Feb 10, 2022 •

edited

Loading

GBKS left a comment

pavlenex left a comment •

edited

Loading

pavlenex Feb 18, 2022

Bosch-0 Feb 21, 2022

GBKS Feb 21, 2022

GBKS left a comment

GBKS Feb 21, 2022

sbddesign left a comment

GBKS commented Mar 4, 2022

Bosch-0 commented Mar 5, 2022

sbddesign left a comment

pavlenex left a comment

pavlenex commented Mar 7, 2022

	Another way a user can request bitcoin is from a withdrawal request. A withdrawal request is a payment request that lets the receiver withdraw bitcoin from another wallet. Unlike previously mentioned payment requests, withdrawal requests are generated by the sender. These can be useful for merchants providing refunds to customers.
	Another way a user can receive bitcoin is from a withdrawal request. A withdrawal request is a payment request that lets the receiver withdraw bitcoin from another wallet. Unlike previously mentioned payment requests, withdrawal requests are generated by the sender. These can be useful for merchants providing refunds to customers.

Updated Payments > Requesting page #651

Updated Payments > Requesting page #651

Conversation

Bosch-0 commented Feb 10, 2022 • edited Loading

GBKS left a comment

Choose a reason for hiding this comment

pavlenex left a comment • edited Loading

Choose a reason for hiding this comment

pavlenex Feb 18, 2022

Choose a reason for hiding this comment

Bosch-0 Feb 21, 2022

Choose a reason for hiding this comment

GBKS Feb 21, 2022

Choose a reason for hiding this comment

GBKS left a comment

Choose a reason for hiding this comment

GBKS Feb 21, 2022

Choose a reason for hiding this comment

sbddesign left a comment

Choose a reason for hiding this comment

GBKS commented Mar 4, 2022

Bosch-0 commented Mar 5, 2022

sbddesign left a comment

Choose a reason for hiding this comment

pavlenex left a comment

Choose a reason for hiding this comment

pavlenex commented Mar 7, 2022

Updated `Payments` > `Requesting` page #651

Updated `Payments` > `Requesting` page #651

Bosch-0 commented Feb 10, 2022 •

edited

Loading

pavlenex left a comment •

edited

Loading