Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide deeper guidance on 0 amount settings for Lightning invoices #641

Closed
moneyball opened this issue Feb 4, 2022 · 4 comments · Fixed by #651
Closed

Provide deeper guidance on 0 amount settings for Lightning invoices #641

moneyball opened this issue Feb 4, 2022 · 4 comments · Fixed by #651
Assignees
Labels
Copy Task is about improving text.

Comments

@moneyball
Copy link
Contributor

Attached is my own personal testing of wallets with 0 amounts. It is a total mess! Muun and Phoenix default to 0 amount, yet most wallets give an error when using them, including Muun!

Hopefully wallets converge on supporting this so this matrix isn’t a mess, but in the mean time the design guide could help a product builder out.

  1. Should a wallet support 0 amount receiving? (I think yes)
  2. Should a wallet default to 0 amount receiving? (I think it depends on use case…but also needs to take into account the current mess of wallet support)
  3. Should a wallet support sending to 0 amount invoices (ie let sender enter amount)? (I think yes, obviously…only reason we’re in this mess is due to an LND security bug that has been fixed but wasn't broadly communicated so the ecosystem is unclear on this)

https://bitcoin.design/guide/payments/request/#amount

image

@moneyball moneyball added the Copy Task is about improving text. label Feb 4, 2022
@GBKS GBKS added the Lightning label Feb 8, 2022
@Bosch-0 Bosch-0 self-assigned this Feb 10, 2022
@GBKS GBKS changed the title Provide deeper guidance on amount for LN invoice Provide deeper guidance on 0 amount settings for Lightning invoices Feb 10, 2022
@Bosch-0
Copy link
Collaborator

Bosch-0 commented Feb 11, 2022

Also tested on Blixt, you can generate and send 0 amount invoices fine

@Bosch-0
Copy link
Collaborator

Bosch-0 commented Feb 12, 2022

Muun allows sending to zero amount invoices on android but not iOS. An issue already existed for this muun/falcon#15

Breez Issue existed from back in August for generating zero amount invoices, bumped the issue up for better visibility breez/breezmobile#556

@Bosch-0
Copy link
Collaborator

Bosch-0 commented Feb 13, 2022

Interesting comment from Breez on this breez/breezmobile#556 (comment)

Receiving zero amount invoices requires changes to the on-the-fly channel creation infrastructure.

@Bosch-0
Copy link
Collaborator

Bosch-0 commented Feb 14, 2022

From tbast at Phoenix: ACINQ/phoenix#248 (comment)

No, this warning cannot be removed yet.
We need recipients to implement lightning/bolts#829 to be completely safe.
Before that, our node, if malicious, could in theory steal the payment, so users should be made aware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Copy Task is about improving text.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants