Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add endpoint to get list of roles where user is a core member #221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(api): add endpoint to get list of roles where user is a core member #221

wants to merge 1 commit into from

Conversation

PranshuNayak
Copy link
Contributor

No description provided.

@PranshuNayak PranshuNayak marked this pull request as ready for review August 23, 2022 12:44
@PranshuNayak PranshuNayak requested a review from Samy-33 August 23, 2022 12:44
@PranshuNayak PranshuNayak linked an issue Aug 23, 2022 that may be closed by this pull request
[API] Endpoint to get list of clubs in which the user is a core/co-coordinator/coordinator #198
Open
Samy-33
Samy-33 requested changes Aug 25, 2022
View reviewed changes
Copy link
Member

@Samy-33 Samy-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. One small change.

api/api/accounts/urls.py Outdated Show resolved Hide resolved
@PranshuNayak
Copy link
Contributor Author

@Samy-33 made the changes

@PranshuNayak
Copy link
Contributor Author

Ready for review

@PranshuNayak
Copy link
Contributor Author

Pending for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aksh-Bansal-dev Aksh-Bansal-dev Aksh-Bansal-dev left review comments

@Samy-33 Samy-33 Samy-33 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API] Endpoint to get list of clubs in which the user is a core/co-coordinator/coordinator
3 participants
@PranshuNayak @Samy-33 @Aksh-Bansal-dev