Debug: Adds RTT support to bootloader #1362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickeZ
force-pushed
the
nickez/bootloader-rtt
branch
6 times, most recently
from
e7cc4b8 to
4481dbf
Compare
benma
reviewed
Feb 6, 2025
src/bootloader/bootloader.c
Outdated
| @@ -206,6 +207,8 @@ void _binExec(void* l_code_addr) | |||
|
|
|||
| static void _binary_exec(void) | |||
| { | |||
| util_log("Jumping to firmware"); | |||
| rust_rtt_flush(); | |||
There was a problem hiding this comment.
should we maybe call this in util_log() by default?
There was a problem hiding this comment.
flush will wait until the debugger reads out the buffer and updates the read pointer. It isn't necessary in general, but if we don't do it here messages from the bootloader might be overwritten by the firmware.
There was a problem hiding this comment.
calling it every time will basically make RTT sync, when its speed/efficiency comes from it being async.
src/platform/platform_init.c
Outdated
| #if defined(BOOTLOADER) | ||
| #define PREFIX "boot" | ||
| #else | ||
| #define PREFIX "app" |
There was a problem hiding this comment.
fw or firmware? to disambiguate from our other use of app (bitcoin/ethereum/u2f/...)
NickeZ
force-pushed
the
nickez/bootloader-rtt
branch
3 times, most recently
from
46bf7be to
4bd813d
Compare
To support "handover" from bootloader to application, the RTT allocations are put in the same places in RAM in both projects. Without this the J-Link software will only find one of the allocations and therefore not read the other.
NickeZ
force-pushed
the
nickez/bootloader-rtt
branch
from
4bd813d to
3e4f0b4
Compare
|
Rebased and fixed the reason it was affecting the release bootloader. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support "handover" from bootloader to application, the RTT allocations are put in the same places in RAM in both projects. Without this the J-Link software will only find one of the allocations and therefore not read the other.
This does not have any impact on non-debug builds.