Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement 97899: Public channel Zaps #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

desousamario85
Copy link
Collaborator

@desousamario85 desousamario85 commented Feb 7, 2025

Description

Add the possiblity to call Zapp.ie from Channels within Teams. This allows users to @Zapp.ie and select one of the commands instead of communicating with Zapp.ie directly in the personal chat. I have removed all the commented out code which is no longer required.

There is an known issue with the Adaptive Card in this repo, which is being resolved separetly.

Bug 99139: Error message in adaptive card

Screenshot/video

image

Related workitems

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Test Instructions

To test this PR:

  1. Run Zapp.ie on your local machine
  2. When Zapp.ie opens in MS Teams, make sure to add Zapp.ie in a Team.
  3. iIn a new post, starting typing with @Zapp.ie and you will see Zapp.ie bot appear from the popup.
  4. Once you selected Zapp.ie the list of commands will appear.
  5. Select one of the commands and ensure they complete the task successfully.

Checklist:

  • My code follows the style guidelines of this project (see "Contribute" in the wiki)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@EdiWeeks EdiWeeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. @BenGWeeks

@BenGWeeks
Copy link
Owner

Plans for using + and then a pop-up?

@desousamario85
Copy link
Collaborator Author

desousamario85 commented Feb 24, 2025

Plans for using + and then a pop-up?

Thin both should be separate enhancement, as both enhancement will need a bit of work.
If we implement + function then we only can only zap current users who have wallets.

Enhancement 99704: Function use + function to call a pop up to send Zaps

@BenGWeeks / @AntonANekrasov FYI

@desousamario85
Copy link
Collaborator Author

@BenGWeeks ready to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants