Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 91938: Signs out when click on Close (X) #68

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Bug 91938: Signs out when click on Close (X) #68

merged 3 commits into from
Feb 4, 2025

Conversation

desousamario85
Copy link
Collaborator

Description

Fixing issue where closing the Popup window displays errors in the console. The authenication method is a duplicate to Alice, which will users to authenticate to Zapp.ie within MS Teams Desktop.

Screenshot/video

Please include a screenshot (or even better a video) of the functionality (if applicable).

Related workitems

  • Bug 91938: Signs out when click on Close (X)

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Test Instructions

To test this PR:

  1. Browse to the Staging URL and Login into Zapp.ie
  2. Open the MS Teams and confirm you are able to login to Zapp.ie

Checklist:

  • My code follows the style guidelines of this project (see "Contribute" in the wiki)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New and existing unit tests pass locally with my changes

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-grass-0cba10710-68.centralus.5.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-grass-0cba10710-68.centralus.5.azurestaticapps.net

@EdiWeeks EdiWeeks self-requested a review January 29, 2025 09:18
@EdiWeeks
Copy link
Collaborator

@desousamario85 please can you fix conflict?

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-grass-0cba10710-68.centralus.5.azurestaticapps.net

@BenGWeeks BenGWeeks merged commit d1082d8 into main Feb 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants