fix(adapter): use set and setex on rediscacheitempooladapter save #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvG
reviewed
Sep 30, 2021
kronostof
force-pushed
the
fix/redis-cache-item-pool-adapter
branch
from
4090889 to
7d1526f
Compare
valentin-claras
approved these changes
Oct 1, 2021
e-zannelli
approved these changes
Oct 4, 2021
kronostof
force-pushed
the
fix/redis-cache-item-pool-adapter
branch
2 times, most recently
from
43a0882 to
2e217e2
Compare
e-zannelli
reviewed
Oct 8, 2021
lnahiro
reviewed
Oct 8, 2021
| ->isInstanceof('Psr\Cache\CacheItemInterface') | ||
| ->string($item->get()) | ||
| ->isEqualTo('myExpirableValue') | ||
| ->if(sleep(1)) |
There was a problem hiding this comment.
you could use usleep for waiting less time
There was a problem hiding this comment.
Could we talk about this point ?
As we use redis-mock i could not check that we the method set with the right argument was call.
As clientItem use millisecond format for time expiration (and for some unknown reasons), using shorter time range than half second introduce some wired false-positive 🤷♂️
There was a problem hiding this comment.
Has we saw together there is an issue on RedisMock-bundle. Ttl resolution by milliseconde could not be use.
kronostof
force-pushed
the
fix/redis-cache-item-pool-adapter
branch
3 times, most recently
from
bbad48e to
80296c7
Compare
kronostof
force-pushed
the
fix/redis-cache-item-pool-adapter
branch
from
80296c7 to
b046946
Compare
lnahiro
approved these changes
Oct 25, 2021
fix(adapter): replace set by set with option on rediscacheitempooladapter
kronostof
force-pushed
the
fix/redis-cache-item-pool-adapter
branch
from
b046946 to
75eed59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
RedisCacheItemPoolAdapterswitch from set declaration on v3.0.0 to set declaration on v6.0.1how
Using set and setex as it should be