Parse GRPC data in ZooKeeper. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OferMania
reviewed
Sep 10, 2019
| external_storage = ctu.external_storage_string(ensemble) | ||
| self.ensemble = {i: '10.0.1.{}'.format(i) for i in xrange(1, num_nodes + 1)} | ||
| zk_servers = ctu.ensemble_servers_string(self.ensemble) | ||
| external_storage = 'zk:' + ctu.external_storage_string(self.ensemble) |
There was a problem hiding this comment.
I understand that, with your change, some calls need the 'zk:' prefix, and other calls do not. but moving the 'zk:' string over to this file for concatenation feels a bit tacky. Wouldn't it be cleaner to simply add a boolean parameter use_zk_prefix for the ctu.external_storage_string() method?
| # Read the ZooKeeper entry for the table and make sure it looks sane. | ||
| # This mostly tests our ability to read from ZooKeeper and parse the | ||
| # GRPC contents correctly. | ||
| table_data = zk_client.get('/ramcloud/main/tables/test')[0] |
There was a problem hiding this comment.
I'm not entirely sure why you're using '/ramcloud/main/tables/test' for table_data. I'm sure there's a good reason. Can I ask you to clarify this in the comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./config/make-ramcloud