Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TruncatedOutput fix #506

Merged
merged 15 commits into from
Jul 30, 2024
Merged

TruncatedOutput fix #506

merged 15 commits into from
Jul 30, 2024

Conversation

mjurbanski-reef
Copy link
Contributor

@mjurbanski-reef mjurbanski-reef commented Jul 30, 2024 •
edited
Loading

The core fix is in reef-technologies@f3f0521 .

The core problem was that:

  • thread pool tasks were never awaited, hence the actual connection errors were silent
  • data streaming errors were not properly try-excepted and therefor single error during data transmission was never retried

Fixes Backblaze/B2_Command_Line_Tool#554

@mjurbanski-reef
add pytest-apiver plugin compatiblity fixture
6a1fbca
@mjurbanski-reef
add Range class unit tests
ef1bd6f
@mjurbanski-reef
make Range class into slotted dataclass
a94199b
@mjurbanski-reef
additional Range.subrange testcase
9deb22e
@mjurbanski-reef
fix SimpleDownloader handling of filesize=0 and release connection pr…
b061b1f 
…operly
@mjurbanski-reef
refactor Content-Range header parsing
9703f48
@mjurbanski-reef
expose EMPTY_RANGE const in API
3d36c7d
@mjurbanski-reef
make sure Range instances are immutable
60e943d
@mjurbanski-reef
ensure FileSimulator.as_download_headers returns dict[str,str]
965240c
@mjurbanski-reef
Improve download_file_from_url methods type hints
80a6112
@mjurbanski-reef
add more type hints
5157074
@mjurbanski-reef
add enter&exit method to FakeResponse
806cc21
@mjurbanski-reef
fix TruncatedOutput errors during downloads over congested network
f3f0521
@mjurbanski-reef
limit Github Actions job to 90 minutes max (instead of default 6h)
269f575
@mjurbanski-reef
workaround for PyPy hangs due non-awaited futures
3d8b680
@mjurbanski-reef mjurbanski-reef merged commit 7535c7a into Backblaze:master Jul 30, 2024
27 checks passed
@mjurbanski-reef mjurbanski-reef deleted the truncation_fix branch July 30, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TruncatedOutput: only 1495314753 of 2121389892 bytes read
1 participant
@mjurbanski-reef