fix(ras-sync): account for missing creation data and first/last name

[dkoo]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Avoids a fatal and accounts for some missing user meta when building contact data for migrated Woo customers. This seems to be an edge case with migrated/imported users as "naturally created" WP users should always have a user_registered value, but we've seen that in rare cases imported users can lack this value.

How to test the changes in this Pull Request:

Since it's impossible to delete the user_registered value from a user once created, we need to use wp shell to simulate the conditions for the error.

1. On release, use wp shell to delete the date_created value and the First and Last Name meta fields from the user (replace 56 with your test user's ID):

> $customer = new WC_Customer( 56 );
= WC_Customer {#16805}

> $customer->set_date_created( null );
= null

> $customer->save();
= 56

> delete_user_meta( 56, 'first_name' );
= true

> delete_user_meta( 56, 'last_name' );
= true

2. While in the same wp shell session, get the contact data and observe a fatal error:

> Newspack\Reader_Activation\Sync\WooCommerce::get_contact_from_customer( $customer );

   Error  Call to a member function date() on null.

3. Check out this branch, start a new wp shell session, and repeat. This time confirm that the contact data gets built, but without a registration_date value:

> $customer = new WC_Customer( 56 );
= WC_Customer {#16805}

> $customer->set_date_created( null );
= null

> $customer->save();
= 56

> delete_user_meta( 56, 'first_name' );
= true

> delete_user_meta( 56, 'last_name' );
= true

> Newspack\Reader_Activation\Sync\WooCommerce::get_contact_from_customer( $customer );
= [
    "email" => "[email protected]",
    "metadata" => [
      "payment_page" => "https://site.url/test"
      "membership_status" => "active",
      "sub_start_date" => "2025-01-14 20:53:22",
      "sub_end_date" => "",
      "billing_cycle" => "month",
      "recurring_payment" => "50.00",
      "last_payment_amount" => "50.00",
      "last_payment_date" => "2025-01-14 20:53:22",
      "next_payment_date" => "2025-02-13 20:53:22",
      "product_name" => "Premium Subscription",
      "payment_page_utm_source" => "",
      "payment_page_utm_medium" => "",
      "payment_page_utm_campaign" => "",
      "payment_page_utm_term" => "",
      "payment_page_utm_content" => "",
      "cancellation_reason" => "",
      "total_paid" => "50.00",
      "account" => 56,
      "registration_date" => "",
    ],
    "name" => "Test User",
  ]

4. Confirm that after calling get_contact_from_customer the billing first/last names are copied to the first_name and last_name user meta fields (this happens automatically when a new user is created during the checkout flow). You can check this in the User admin page for this user, or via wp user meta list <user ID> in WP CLI.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1209154944954046

[matticbot]

🎉 This PR is included in version 5.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀